Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Fixed AssetsPlugin picking up hmr update pathes for index chunk #567

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Fixed AssetsPlugin picking up hmr update pathes for index chunk #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions internal/webpack/configFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export default function webpackConfigFactory(buildOptions) {
// Otherwise we expect our bundled client to be served from this path.
bundleConfig.webPath,
),
hotUpdateChunkFilename: '[hash].hot-update.js', // needed for AssetsPlugin to filter out hmr updates
},

target: isClient
Expand Down Expand Up @@ -320,12 +321,7 @@ export default function webpackConfigFactory(buildOptions) {
ifDev(() => new webpack.NoEmitOnErrorsPlugin()),

// We need this plugin to enable hot reloading of our client.
ifDevClient(
() =>
new webpack.HotModuleReplacementPlugin({
multiStep: true,
}),
),
ifDevClient(() => new webpack.HotModuleReplacementPlugin()),

// For the production build of the client we need to extract the CSS into
// CSS files.
Expand Down