Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

babel-preset-env usage adjustment #531

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

strues
Copy link
Collaborator

@strues strues commented Oct 19, 2017

This switches how babel-preset-env is used. Currently we look like

['env', { 
     es2015: { modules: false }
}]

The es2015 portion was dropped a while back if I remember right. Nothing in the babel docs mentions using it any more. Figured we'd reflect the documentation.

As a side note, running the preset w/ debug: true appears to produce the exact same output 馃槙

@ctrlplusb
Copy link
Owner

Interesting, thanks for tracking the updates @strues

@ctrlplusb
Copy link
Owner

@strues so I believe the original intention of ignoring modules was because webpack understands es modules and we wanted webpack to do any possibly optimisations it could (dead code elimination / tree shaking). I checked create-react-app which is a great benchmark for babel configurations and it appears they are still ignoring modules too - likely for the reason I just described. Thoughts?

@oyeanuj oyeanuj mentioned this pull request Oct 29, 2017
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants