Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle build script #67

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TheTeXnician
Copy link

This addresses #46 and adds a Gradle build script that is able to build and test the project. For publishing there are two points to consider:

This is not intended to be a full-featured transition but a start for the Gradle build system. Hence, it is an addition to the current Maven POM.

@koppor
Copy link

koppor commented Oct 24, 2020

Why do the files take a .kts extension?

@koppor
Copy link

koppor commented Oct 24, 2020

I would recommend to add a gradle wrapper to enable a self-contained repository (only JDK will be needed then).

Thereby, I would also propose to add a gradle wrapper validation

@TheTeXnician
Copy link
Author

Why do the files take a .kts extension?

Because the Gradle Kotlin DSL is Kotlin Script which has the .kts extension. See also https://docs.gradle.org/current/userguide/kotlin_dsl.html#sec:scripts.

@TheTeXnician
Copy link
Author

I would recommend to add a gradle wrapper to enable a self-contained repository (only JDK will be needed then).

Thereby, I would also propose to add a gradle wrapper validation

This is a great idea. I usually also do this, so I don't know why I did not add the wrapper. And the GitHub actions workflow looks very promising.

@koppor
Copy link

koppor commented Oct 24, 2020

Why do the files take a .kts extension?
Because the Gradle Kotlin DSL is Kotlin Script which has the .kts extension. See also docs.gradle.org/current/userguide/kotlin_dsl.html#sec:scripts.

Oh, wow, never saw Kotlin-based gradle build files until now.

@TheTeXnician
Copy link
Author

@koppor Thanks for your suggestion. I have added the Gradle wrapper and the wrapper validation workflow in the commits fd68d1b and bcca640.

Oh, wow, never saw Kotlin-based gradle build files until now.

They stabilized the Kotlin DSL a while ago. And as the issue title of #46 mentions "Gradle (kt)" I thought @ctongfei intended to transition to Kotlin DSL gradle builds.

@TheTeXnician
Copy link
Author

I have updated this branch to the current master (e8fd860). Probably it should be squashed when merging if it is going to be merged at some point. As there has not been a comment for over 6 months until now, it is likely it will remain dormant for some more time (just ping me if it needs updates)…

Base automatically changed from master to main March 9, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants