Fix for missing dynamic rules #1642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
reviewed
Apr 5, 2023
| @@ -114,7 +114,10 @@ export default class RuleList { | |||
| remove(rule) { | |||
| this.unregister(rule) | |||
| delete this.raw[rule.key] | |||
| this.index.splice(this.index.indexOf(rule), 1) | |||
There was a problem hiding this comment.
In fact, it should work with indexOf, while only adding the -1 check, right? If help is needed, I can try myself. What else is needed to merge the PR? Some tests?
There was a problem hiding this comment.
I lack the greater context to effectively debug the reason why is 'find by reference' not working.
In fact, it should work with indexOf, while only adding the -1 check, right?
If we checked only for -1 it wouldn't be removing old styles
|
Hi @Bundas, just wanted to know if there are any updates about this. Can I help in some way? Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding Issue(s):
What Would You Like to Add/Fix?
#1635
Todo
Expectations on Changes
Changelog