Use universal darwin build for previous crystal #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
darwin-iniversal
branch
from
64b5fae
to
812313a
Compare
miry
force-pushed
the
darwin-iniversal
branch
from
812313a
to
1d8b346
Compare
|
checking failed test |
miry
commented
Nov 13, 2023
miry
force-pushed
the
darwin-iniversal
branch
from
1d8b346
to
f14d932
Compare
|
Updated the code to use |
For last crystal releases there is only crystal-darwin-universal. It means, there is no need to separate on ARCH. Update `darwin/Makefile` to use folder name without arch suffix.
miry
added a commit
to miry/distribution-scripts
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For last few crystal releases there is only crystal-darwin-universal.
It means, there is no need to separate on ARCH in Makefiles or folder names for
darwin.Update
darwin/Makefileto use folder name without arch suffix.Example usage:
my level of understanding the whole process: noob