Fix shell.nix use llvmPackages.bintools with wrapper for rpath config
#14583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beta-ziliani
approved these changes
May 10, 2024
straight-shoota
changed the title
llvmPackages.bintools with wrapper for rpath confignix.shell use llvmPackages.bintools with wrapper for rpath config
straight-shoota
changed the title
nix.shell use llvmPackages.bintools with wrapper for rpath configshell.shell use llvmPackages.bintools with wrapper for rpath config
straight-shoota
changed the title
shell.shell use llvmPackages.bintools with wrapper for rpath configshell.nix use llvmPackages.bintools with wrapper for rpath config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blank
lldpackage is unwrapped and does not have the proper rpath configuration, so the loader wouldn't find all libraries.With this patch, everything works fine.
This is particularly relevant for
EXPORT_CCinMakefilewhich configures to uselld.Ref: NixOS/nixpkgs#24744 (comment)