Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BigRational#format #14525

Merged
merged 7 commits into from
May 21, 2024
Merged

Fix BigRational#format #14525

merged 7 commits into from
May 21, 2024

Commits on Apr 22, 2024

  1. Add specefic format logic for BigRational

    @meatball133
    meatball133 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d7ccb99 View commit details
    Browse the repository at this point in the history

  2. Change so the code doesnt depend on Big to be imported

    @meatball133
    meatball133 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9e1b57d View commit details
    Browse the repository at this point in the history

  3. Implement the logic as an override

    @meatball133
    meatball133 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9df1d97 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Fixes and improvements based on feedback

    @meatball133
    meatball133 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9cf2114 View commit details
    Browse the repository at this point in the history

  2. Format + addition of specs

    @meatball133
    meatball133 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    70732f3 View commit details
    Browse the repository at this point in the history

  3. Pass io to format

    @meatball133
    meatball133 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    88aae50 View commit details
    Browse the repository at this point in the history

  4. Flip the numbers and remove self

    @meatball133
    meatball133 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c7b1ca1 View commit details
    Browse the repository at this point in the history