Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Crystal::Select::When with Crystal::When #14497

Merged
merged 2 commits into from May 14, 2024

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Apr 16, 2024

Alternative to / closes #14493

@straight-shoota
Copy link
Member

This is probably a good idea, yet we should consider potential consequences. I don't think there's a huge impact. #14493 (comment) mentions smaller memory footprint, but that's not very relevant considering select statements are pretty rare and typically have only a handfull of branches.

There's a chance that the syntax for when in select and case might evolve into different directions in the future. I don't see anything like that happening and if it does we could still consider going back to different types.

@beta-ziliani beta-ziliani added this to the 1.13.0 milestone May 10, 2024
@straight-shoota straight-shoota merged commit 361f7ea into crystal-lang:master May 14, 2024
59 of 60 checks passed
@HertzDevil HertzDevil deleted the refactor/select-when2 branch May 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants