Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace log.Fatal with error return #2996

Merged
merged 3 commits into from
May 17, 2024
Merged

replace log.Fatal with error return #2996

merged 3 commits into from
May 17, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 13, 2024

No description provided.

@mmetc mmetc added this to the 1.6.2 milestone May 13, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 26.08696% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 27.52%. Comparing base (0ba05ac) to head (642a8fb).

Files Patch % Lines
pkg/apiserver/papi.go 0.00% 5 Missing ⚠️
pkg/cache/cache.go 55.55% 4 Missing ⚠️
pkg/hubtest/hubtest_item.go 0.00% 3 Missing ⚠️
pkg/leakybucket/manager_load.go 0.00% 3 Missing ⚠️
pkg/csprofiles/csprofiles.go 50.00% 1 Missing ⚠️
pkg/parser/node.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2996   +/-   ##
=======================================
  Coverage   27.52%   27.52%           
=======================================
  Files         398      398           
  Lines       58142    58148    +6     
=======================================
+ Hits        16005    16007    +2     
- Misses      40192    40195    +3     
- Partials     1945     1946    +1     
Flag Coverage Δ
unit-linux 34.87% <6.66%> (-0.01%) ⬇️
unit-windows 25.59% <26.08%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the 1.6.2-fatal branch 2 times, most recently from 52ddc98 to f25acd0 Compare May 15, 2024 07:29
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 1a4ac9d into master May 17, 2024
15 checks passed
@mmetc mmetc deleted the 1.6.2-fatal branch May 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants