Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postoverflow] Reinject meta into overflown state #2502

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

LaurenceJJones
Copy link
Contributor

#1337

This one is difficult to find an appropriate fix..... since Meta is converted to events on "overflow" anything set in meta in postoverflow stage is never carried beyond. This PR re injects all meta objects across all events, to make sure the user has it.

I am primarily looking for feedback as I couldnt really see any other property without creating a new one but we already have too many "meta" properties.

@github-actions
Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 57.95%. Comparing base (4bf640c) to head (dfee2f1).

Files Patch % Lines
cmd/crowdsec/output.go 0.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2502   +/-   ##
=======================================
  Coverage   57.94%   57.95%           
=======================================
  Files         240      240           
  Lines       31039    31048    +9     
=======================================
+ Hits        17986    17993    +7     
- Misses      11418    11421    +3     
+ Partials     1635     1634    -1     
Flag Coverage Δ
bats 37.93% <0.00%> (+0.04%) ⬆️
unit-linux 52.30% <ø> (+0.03%) ⬆️
unit-windows 47.75% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones added this to the 1.5.6 milestone Oct 24, 2023
@sabban sabban self-assigned this Dec 4, 2023
@sabban sabban self-requested a review December 5, 2023 07:49
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc modified the milestones: 1.5.6, 1.6.1 Jan 24, 2024
@blotus blotus modified the milestones: 1.6.1, 1.6.3 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants