Adding of features asked for in issue #397 #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added shortcuts for clearing source text, switching languages and switching engine in settings
Added the requiere lines to be able to save the shortcuts
Assigned the clear text shortcut to its existing button in the main UI
Shatur
requested changes
Dec 18, 2023
Comment on lines
+328
to
+342
| QKeySequence clearShortcut() const; | ||
| void setClearShortcut(const QKeySequence &shortcut); | ||
| static QKeySequence defaultClearShortcut(); | ||
|
|
||
| QKeySequence switchSourceShortcut() const; | ||
| void setSwitchSourceShortcut(const QKeySequence &shortcut); | ||
| static QKeySequence defaultSwitchSourceShortcut(); | ||
|
|
||
| QKeySequence switchTranslationShortcut() const; | ||
| void setSwitchTranslationShortcut(const QKeySequence &shortcut); | ||
| static QKeySequence defaultSwitchTranslationShortcut(); | ||
|
|
||
| QKeySequence switchEngineShortcut() const; | ||
| void setSwitchEngineShortcut(const QKeySequence &shortcut); | ||
| static QKeySequence defaultSwitchEngineShortcut(); |
There was a problem hiding this comment.
You need to add definitions of these function in appsettings.cpp.
There was a problem hiding this comment.
I'm afraid i don't really know how this would be done
There was a problem hiding this comment.
Just look into similar functions and copy them with minor edits :)
There was a problem hiding this comment.
I would suggest to start with clear button. Just only this one in this PR to learn how it's usually done.
| @@ -1063,6 +1063,7 @@ void MainWindow::loadAppSettings() | |||
| ui->translateButton->setShortcut(settings.translateShortcut()); | |||
| ui->swapButton->setShortcut(settings.swapShortcut()); | |||
| ui->copyTranslationButton->setShortcut(settings.copyTranslationShortcut()); | |||
| ui->clearButton->setShortcut(settings.clearShortcut()); | |||
There was a problem hiding this comment.
This is correct, but you also need to assign other buttons. Search for their names in mainwindow.ui
There was a problem hiding this comment.
I don't think there are buttons for the other actions. I don't have the knowledge to code them either, sadly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More than a year ago i suggested what keymaps to be used for the shortcuts asked in #397. Maintainer explained what would have to be done in the code to add these to the project, but i preferred to left that to someone else back then because i have almost no knowledge of C++ or programming in general. Since the Issue thread went silent after that, i eventually decided to give it a try and do it myself following the instruction of Shatur. I don't think i knew what i was doing and I'm not sure if i did it right, if i forgot something, if i followed the style of the project or if i broke things rather than improving them, but i hope these commits will at least be helpful in finally adding the features and closing the issue.
I'll await for your feedback and corrections.