-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(decide/match): support multi-file risky based matching #689
Conversation
ee8c42e
to
1a809e3
Compare
1a809e3
to
c892dcc
Compare
c892dcc
to
c391a96
Compare
c391a96
to
2102356
Compare
2102356
to
df785a1
Compare
df785a1
to
e4d24a1
Compare
e4d24a1
to
b4b7922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
architecture looks good, I like the new organization of decide.ts
. I have several comments but they're pretty minor for the most part
b4b7922
to
8865364
Compare
8865364
to
589806d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the resolution of these threads:
589806d
to
30ade1b
Compare
30ade1b
to
b046a69
Compare
b046a69
to
74a217d
Compare
Good to merge. Had to update |
#695 ? |
This mainly is to support multi-file risky based matching moving the 100% MATCH_PARTIAL matches to MATCH_SIZE_ONLY. I refactored decide.js to the state it will be downstream.
1st commit:
cache-search-queries
). We can optionally cleanup based on modified time since it is updated each time it's used.2nd commit: