Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(decide/match): support multi-file risky based matching #689

Merged
merged 2 commits into from
May 29, 2024

Conversation

ShanaryS
Copy link
Contributor

@ShanaryS ShanaryS commented May 17, 2024

This mainly is to support multi-file risky based matching moving the 100% MATCH_PARTIAL matches to MATCH_SIZE_ONLY. I refactored decide.js to the state it will be downstream.

1st commit:

  1. The priority of decisions
  2. Reporting more granular decisions
  3. Caching all snatched .torrent files and saving infoHash with decision if present (might as well start doing this now for cache-search-queries). We can optionally cleanup based on modified time since it is updated each time it's used.
  4. Better error message for decisions and snatch.

2nd commit:

  1. Support multi-file risky based matches

@ShanaryS ShanaryS added search Related to search enhancement enhances existing features labels May 17, 2024
@ShanaryS ShanaryS self-assigned this May 17, 2024
Copy link
Collaborator

@mmgoodnow mmgoodnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

architecture looks good, I like the new organization of decide.ts. I have several comments but they're pretty minor for the most part

src/decide.ts Outdated Show resolved Hide resolved
src/decide.ts Outdated Show resolved Hide resolved
src/decide.ts Show resolved Hide resolved
src/decide.ts Outdated Show resolved Hide resolved
src/decide.ts Outdated Show resolved Hide resolved
src/pipeline.ts Outdated Show resolved Hide resolved
src/torrent.ts Outdated Show resolved Hide resolved
src/torrent.ts Outdated Show resolved Hide resolved
src/torrent.ts Outdated Show resolved Hide resolved
src/torrent.ts Show resolved Hide resolved
mmgoodnow
mmgoodnow previously approved these changes May 29, 2024
Copy link
Collaborator

@mmgoodnow mmgoodnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the resolution of these threads:

#689 (comment)
#689 (comment)

@ShanaryS
Copy link
Contributor Author

Good to merge. Had to update humanReadable to use absolute values for Math.log.

@zakkarry
Copy link
Collaborator

Good to merge. Had to update humanReadable to use absolute values for Math.log.

#695 ?

@mmgoodnow mmgoodnow merged commit 323c086 into master May 29, 2024
5 checks passed
@mmgoodnow mmgoodnow deleted the risky-multi-file-support branch May 29, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bt client daemon enhancement enhances existing features search Related to search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants