DefaultLogger: Buffer log output until the log output is configured #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 94.96% 95.88% +0.91%
==========================================
Files 21 22 +1
Lines 576 656 +80
==========================================
+ Hits 547 629 +82
+ Misses 21 19 -2
Partials 8 8
☔ View full report in Codecov by Sentry. |
jkellerer
force-pushed
the
ft/buffer-default-log
branch
from
430610e
to
d9195dd
Compare
jkellerer
force-pushed
the
ft/buffer-default-log
branch
from
d9195dd
to
a76c797
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Oct 14, 2023
|
Nice one 👍🏻 thanks for that 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents any log output from the default logger until a log output handler or a new default logger is configured.
Log is buffered by up to 2MB and discarded completely if the buffer is exceeded and no output was configured. Any buffered log is sent to the output handler when set.