Update to go-1.21 #4139
Update to go-1.21 #4139
Conversation
|
/retest |
|
|
@cfergeau only on windows-2019 and windows-2022 it is working as expected, I will check what's is happening there. |
There was a problem hiding this comment.
Fwiw, we used to have a similar workaround 1b6bf222090f
I don't know what "win-2022 also have OS-10.0.x build" means.
Do you suggest that we should use a hack keep the
I took it that it have some similarity with win-10 but as per https://en.wikipedia.org/wiki/Windows_Server_2022 looks like codebase is different Windows Server 2022 is based on the "Iron" codebase.[5] Its updates are incompatible with the Windows 10 operating system, as the "Iron" codebase was not used for it.[5] Like its predecessor, Windows Server 2019, it requires x64 processors. I think we can keep windows-2022 till it is working and remove it if that also starts failing because now we already have win-10/11 for e2e added as gh-action. |
I only mean that I don't find the argument "we need a workaround to keep the win2019 runners" very convincing when we already had a similar workaround in the past.
Fine with me, not even sure win2022 brings much as we have win10/win11 e2e? |
removed it from the commit message. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cfergeau because of RHEL-8.10 still not out? /hold |
In a more general way, we don't want to discover during the release that "something" was not ready for go 1.21. But yes, I think we do our linux release builds on a rhel8, so this is one good reason for waiting with this change. |
|
New changes are detected. LGTM label has been removed. |
praveenkumar
changed the title
RHEL-9.4 and RHEL-8.10 is released and have golang-1.21 as part of go-toolset, same with the ubi9/ubi8 go-toolset images. This PR do followingings - Update github actions to go-1.21 - Use rhel-8-release-golang-1.21-openshift-4.16 image tag instead rhel-8-release-golang-1.20-openshift-4.15 because openshift-4.15 doesn't have golang-1.21 tag.
It's been deprecated in go 1.21: https://pkg.go.dev/crypto/elliptic#Marshal > Deprecated: for ECDH, use the crypto/ecdh package. This function > returns an encoding equivalent to that of PublicKey.Bytes in > crypto/ecdh. This fixes a `make lint` failure.
Looks like with `go-1.21` this job is failing because of outdate Mingw version microsoft/go#1081 and there is hack to make it work https://github.com/containerd/containerd/pull/9288/files.
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.