Move download directory configuration to .rtorrent.rc #181
+8
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue of download paths not being easily configurable (#105, #7, #44, #57).
As @crazy-max said in his comment on #105 the conventional solution here is to use bind-mounts rather than changing directories in-solution.
@hollanbm, however, raised an important scenario in which that is not applicable. If this container needs to communicate paths to external services, simply using a bind mount is not a viable solution. One might think it's just easy enough to add the
/downloads
mount on any other container that needs access to the path, but this breaks hardlinking. A file can't be hardlinked across bind mounts. As such, the only solution is to change the paths in the configuration file.This PR simply moves the configuration of download paths from
.rtlocal.rc
, which is effectively read-only, to.rtorrent.rc
, which can modified by the user without having to rebuild the container.