Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current AWS credentials configuration requires a static IAM access key and secret. However, the AWS SDK can automatically handle providing credentials from IAM instance roles, as well as through service account tokens using IRSA in Kubernetes.
To allow these auth methods, skip setting the static credentials provider unless static credentials are provided. This allows the other authentication methods to be handled transparently if available.
The downside of this change is that it provides a less clear error message if all authentication methods are entirely missing, however the ability to use other credential chains is probably worth it.
I've tested this by simulating the container running as a Kubernetes pod using IRSA with the following configuration:
And using static credentials
Also, this is my first time writing go code, so if you have style feedback that is appreciated.