Client remote control

[alex-Arc]

#781 continued here

TODO

• Make nice overlay
• styling the client list
• Handle multiple tabs

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (33)

• apps/client/src/App.tsx is excluded by none and included by none
• apps/client/src/AppRouter.tsx is excluded by none and included by none
• apps/client/src/common/api/constants.ts is excluded by none and included by none
• apps/client/src/common/components/client-modal/ClientModal.module.scss is excluded by none and included by none
• apps/client/src/common/components/client-modal/RedirectClientModal.tsx is excluded by none and included by none
• apps/client/src/common/components/client-modal/RenameClientModal.tsx is excluded by none and included by none
• apps/client/src/common/components/identify-overlay/IdentifyOverlay.module.scss is excluded by none and included by none
• apps/client/src/common/components/identify-overlay/IdentifyOverlay.tsx is excluded by none and included by none
• apps/client/src/common/components/navigation-menu/NavigationMenu.tsx is excluded by none and included by none
• apps/client/src/common/components/navigation-menu/rename-client-modal/RenameClientModal.tsx is excluded by none and included by none
• apps/client/src/common/hooks/useClientPath.ts is excluded by none and included by none
• apps/client/src/common/hooks/useSocket.ts is excluded by none and included by none
• apps/client/src/common/stores/clientStore.ts is excluded by none and included by none
• apps/client/src/common/stores/connectionName.ts is excluded by none and included by none
• apps/client/src/common/utils/socket.ts is excluded by none and included by none
• apps/client/src/features/app-settings/AppSettings.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/panel/Panel.module.scss is excluded by none and included by none
• apps/client/src/features/app-settings/panel/client-control-panel/ClientControlPanel.module.scss is excluded by none and included by none
• apps/client/src/features/app-settings/panel/client-control-panel/ClientControlPanel.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/panel/client-control-panel/ClientList.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/panel/log-panel/LogPanel.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/panel/network-panel/NetworkInterfaces.module.scss is excluded by none and included by none
• apps/client/src/features/app-settings/panel/network-panel/NetworkInterfaces.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/panel/network-panel/NetworkLogExport.module.scss is excluded by none and included by none
• apps/client/src/features/app-settings/panel/network-panel/NetworkLogExport.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/panel/network-panel/NetworkLogPanel.tsx is excluded by none and included by none
• apps/client/src/features/app-settings/settingsStore.ts is excluded by none and included by none
• apps/client/src/theme/_ontimeStyles.scss is excluded by none and included by none
• apps/server/src/adapters/WebsocketAdapter.ts is excluded by none and included by none
• apps/server/src/api-integration/integration.controller.ts is excluded by none and included by none
• e2e/tests/features/302-client-remote.spec.ts is excluded by none and included by none
• packages/types/src/definitions/Clients.type.ts is excluded by none and included by none
• packages/types/src/index.ts is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alex-Arc]

@jwetzell if you could give this feature a try that would be very welcome

i find it easiest to test by open one window to http://localhost:3000/editor?settings=network__clients and the another one in incognito mode, this way they don't share local storage

[jwetzell]

I don't really know what is being added. I did pull this branch and run it. If I open 2 tabs (one in incognito) I see 2 entries in Ontime client and can interact with them and redirect and identify work.

[alex-Arc]

Thank you, that's it
The ability to remote-control ontime clients

Any comments on the UI or the like? was it somewhat intuitive?

[jwetzell]

Seems to be, I didn't immediately understand what redirect would do but simple enough to just try it out

[cpvalente]

@alex-Arc
Seems like there is something broken ?

[alex-Arc]

yeah name and path are unknown at start up