Add insulinDelivery support for iOS #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to write insulin delivery to apple health we need to provide a reason (basal vs bolus) so I've decided to create a new method channel for it. Please check if that makes sense to you! Also check if exposing metadata on HealthDataPoint makes sense. |
|
@MadsVSChristensen sorry to tag you, but just wanted to ask if it's possible to consider this pull request for future releases? Cheers |
added 3 commits
July 28, 2023 11:55
biklas7
commented
Sep 1, 2023
|
@hoffmatteo I've just merged this branch with the latest changes so it should be easier to review, whenever you find time to pick this up 🙂 |
|
Sorry, this PR had some issues, but now everything is working as expected and updated until version 8.1.0, ready for review and merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #674