Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Qdrant storage connector #1023

Merged
merged 63 commits into from
Jun 5, 2024
Merged

feat: Qdrant storage connector #1023

merged 63 commits into from
Jun 5, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Feb 17, 2024

Description

This PR adds support for Qdrant - https://qdrant.tech/ to be used as a storage connector.

Tests

  • Tests have been configured using a Qdrant server at port 6333 for tests/test_storage.py and tests/load_archival.py.
  • A CI service has been set up to launch Qdrant.

If a Qdrant instance is not running or the client library is not installed the Qdrant tests are skipped.

To run Qdrant server

docker run -p 6333:6333 qdrant/qdrant

@Anush008
Copy link
Contributor Author

Hi @cpacker. Could you please take a look when possible please?

tests/test_load_archival.py Outdated Show resolved Hide resolved
@sarahwooders
Copy link
Collaborator

Thanks for submitting this PR! We are happy to support more storage backends, however since we are a fairly small team, we ask that external contributors continue to maintain their storage integrations over time. MemGPT is under active development, so it's possible that the storage connectors will need to be refactored or modified in the future, and our team can only commit to maintaining the default storage connectors.

@Anush008
Copy link
Contributor Author

Hi, @sarahwooders. I've rechecked the implementation as per recent updates. Please take a look when possible.

@Anush008
Copy link
Contributor Author

An update.

  • The dependency on the qdrant-client library is now optional with a qdrant extra.
  • Updated and verified the tests.
  • Qdrant container for CI is set up.

@Anush008
Copy link
Contributor Author

Anush008 commented Jun 5, 2024

Failing https://github.com/cpacker/MemGPT/actions/runs/9253848636/job/25755429975?pr=1023 appears to be due to missing credentials.

Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for the contribution! we can update the documentation sometime tomorrow

pyproject.toml Outdated Show resolved Hide resolved
@sarahwooders sarahwooders merged commit 19480ec into cpacker:main Jun 5, 2024
9 of 11 checks passed
@Anush008
Copy link
Contributor Author

Anush008 commented Jun 5, 2024

docs/storage.md is updated though.

ajanitshimanga pushed a commit to ajanitshimanga/MemGPT that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants