This repository has been archived by the owner on Nov 2, 2021. It is now read-only.
Fixes the weird placeholder strings appearing when language was changed #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2507
A brief description of what changes your PR introduces. The better this description, the quicker we can review, exchange feedback, and merge!
After changing language the placeholder was displaying weird strings and not the cities suggestion you added it was happening because of useCallback function that starts running and do not terminate the priveous instance of useCallback I added language dependency to useCallback and function will terminate whenever the language state changes.
Fixes #2507
✔️ Compiles and passes lint tests
✔️ Properly formatted
✔️ Tested on desktop
✔️ Tested on phone
Before Fixing Screenshot :
Initially wrong strings
After Fixing Screenshots
: