Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Improv: Color code notifications in updates #1450

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improv: Color code notifications in updates #1450

wants to merge 5 commits into from

Conversation

kalesourabh01
Copy link

@kalesourabh01 kalesourabh01 commented Apr 23, 2020 •
edited

Description of PR

Type of PR

  • Bugfix
  • New feature

Relevant Issues
Fixes #...

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots

@vercel
Copy link

vercel bot commented Apr 23, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19india/covid19india-react/15vd1h3th
✅ Preview: https://covid19india-react-git-fork-kalesourabh01-master.covid19india.now.sh

@chatRG
Copy link

chatRG commented Apr 23, 2020

Great work.
BTW, few notification item font is unchanged.

image

@jeremyphilemon jeremyphilemon changed the title The font colors at notification area #1159 Improv: Color code notifications in updates Apr 24, 2020
@kalesourabh01
Copy link
Author

kalesourabh01 commented Apr 28, 2020 •
edited

@chatRG will you review this pull request

image

kalesourabh01
kalesourabh01 commented Apr 28, 2020
View reviewed changes
Copy link
Author

@kalesourabh01 kalesourabh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review this one

@saifeesl
Copy link

saifeesl commented May 1, 2020

This looks great saurabh, numbers needs to be part of it. together will give better visibility. still number black color

@kalesourabh01
Copy link
Author

@saifeesl I have replaced string by name with colors API does not support a proper return format. so I do not consider it or we need to change the return format for it.

@stale
Copy link

stale bot commented Jun 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned issue is no longer important to the requestor and no one else has shown an interest in it label Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Abandoned issue is no longer important to the requestor and no one else has shown an interest in it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalesourabh01 @chatRG @saifeesl