Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for downloading subtitles in README #530

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bandupahile
Copy link

@bandupahile bandupahile commented Aug 23, 2018

馃毃Please review the guidelines for contributing to this repository.

Proposed changes

I have added instructions in README for downloading subtitles during/after the course has been downloaded. This is in response to a suggestion by @rbrito in #524

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • [ x ] I have read the CONTRIBUTING doc
  • [ x ] I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • [ x ] I have added necessary documentation (if appropriate)

Further comments

--

Reviewers

@rbrito

kareemadel and others added 4 commits July 5, 2018 10:34
adjust the name input of the SubSection to the new HTML structure
Added simple scripts for downloading subtitles for some common scenarios.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.7% when pulling 6e3b77f on bandupahile:master into 265718c on coursera-dl:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.7% when pulling 6e3b77f on bandupahile:master into 265718c on coursera-dl:master.

@bandupahile bandupahile changed the title Instructions for downloading subtitles in README Added instructions for downloading subtitles in README Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants