Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the issue with html tag change #519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yeguang-xue
Copy link

Fixing the issue with HTML tag change (from span to div).

馃毃Please review the guidelines for contributing to this repository.

Proposed changes

The bug due to HTML tag change in the website is fixed.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This just involves change of a single line for bug fixing.

Reviewers

N/A

Fixing the issue with HTML tag change (from span to div).
@coveralls
Copy link

coveralls commented Jul 10, 2018

Coverage Status

Coverage remained the same at 48.016% when pulling c5140a7 on blackholexyg:patch-html-tag-change into 55f6e51 on coursera-dl:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants