defined a magic number for stun fingerprinting #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redraincatching
force-pushed
the
fingerprint_magic_number
branch
from
0eeced3
to
5957a37
Compare
eakraly
approved these changes
May 27, 2024
maddymeows
pushed a commit
to maddymeows/coturn
that referenced
this pull request
Jun 2, 2024
The value `0x5354554e`, used twice in the `ns_turn_msg.c`, was unclear, and was changed to a macro that better explained its usage, as defined in [RFC 5389](https://datatracker.ietf.org/doc/html/rfc5389#section-15.5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value
0x5354554e, used twice in thens_turn_msg.c, was unclear, and was changed to a macro that better explained its usage, as defined in RFC 5389