added support for amazon linux and renamed tests.yml #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggarber
reviewed
Apr 19, 2024
.github/workflows/codeql.yml
Outdated
| @@ -2,10 +2,10 @@ name: "CodeQL" | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ 'master' ] | |||
| # branches: [ 'master' ] | |||
There was a problem hiding this comment.
Is this change related to this PR?
There was a problem hiding this comment.
i don't believe it was, have resolved it now
ggarber
approved these changes
Apr 19, 2024
redraincatching
force-pushed
the
amazon-linux
branch
from
1d22e5e
to
e561ce3
Compare
|
Hi @redraincatching ! Could you please rebase your changes so we can merge them? |
redraincatching
force-pushed
the
amazon-linux
branch
from
e561ce3
to
ebb81e4
Compare
|
@eakraly rebased and ready to merge ! |
jonesmz
reviewed
May 30, 2024
redraincatching
force-pushed
the
amazon-linux
branch
from
ebb81e4
to
8ee1e7f
Compare
eakraly
reviewed
Jun 2, 2024
.github/workflows/ubuntu_tests.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ 'ubuntu:16.04', 'ubuntu:18.04', 'ubuntu:20.04', 'ubuntu:22.04' ] | |||
| os: [ 'ubuntu:18.04', 'ubuntu:20.04', 'ubuntu:22.04' ] | |||
There was a problem hiding this comment.
Please return ubuntu 16.04 - we are still not ready to let it go
There was a problem hiding this comment.
that has been returned
jonesmz
reviewed
Jun 2, 2024
| yum install -y gcc make gzip tar openssl-devel libevent-devel | ||
| # Delay checkout until after dependencies have been installed. Amazon linux is very minimal and lacks basic stuff by default. | ||
| # use v3 of checkout until the weird container, nodejs, glibc issue is fixed | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
the glibc errors still seem to be present for amazon linux 2 for version 4
redraincatching
force-pushed
the
amazon-linux
branch
from
455eb0b
to
0804701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseding changes made in pr #1394 on request of @jonesmz
dependent on pr #1399 - uses the composite action for dependency installation i wrote there
added YAML file for amazon linux and renames tests.yml to ubuntu_tests.yml for clarity