ICS 18: specifying events emitted by core IBC #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great initiative |
hdevalence
reviewed
Jun 12, 2023
| IBC that relayers need to use to complete client, connection and channel lifecycles, relay and | ||
| timeout packets. | ||
|
|
||
| Events emitted by core IBC are JSON-encoded objects following the schema: |
There was a problem hiding this comment.
Why are events JSON-encoded, rather than proto-encoded like other IBC data?
There was a problem hiding this comment.
cosmos/ibc-go#54 but can't really speak on if/when this will be included.
AdityaSripal
requested changes
Jun 14, 2023
Comment on lines
+449
to
+450
| "key": "counterparty_connection_id", | ||
| "value": "{counterparty.connectionId}" |
There was a problem hiding this comment.
This should be removed. It is blank here and autogenerated on TRY
Comment on lines
+559
to
+560
| "key": "counterparty_channel_id", | ||
| "value": "{counterparty.channelId}" |
There was a problem hiding this comment.
This should be removed since it is just blank and autogenerated on TRY
| }, | ||
| { | ||
| "key": "connection_id", | ||
| "value": "{connectionHops[0]}" |
There was a problem hiding this comment.
Note this will need to change for multihop. Perhaps we can create a tracking issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #606