Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When performing an action using this widget, I think it would be useful to convey a
loading
state before the slider iscomplete
orreset
. This PR attempts to allow consuming apps to perform some work i.e. call an API, set the slider into aloading
state and then once the work is complete, have the slider continue its complete animation.Loading slider example
Event logs with loading callback
Related PRs/Issues
#116
Todos
Please treat this PR as a prompt to a discussion rather than a mergeable PR as I'd imagine we'd want the
loading
icon to act like a spinner or perhaps allow the animation to be defined in an attribute on the slider?Look forward to a review when you get the chance.