New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve unlinking files in pdf generation #2294

Merged

dpfaffenbauer merged 1 commit into coreshop:3.0 from solverat:wk_file_fix

May 26, 2023

Contributor

solverat commented May 26, 2023

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no

$file can be null, it is not allowed to pass nullin unlink
Use file_exists instead of @unlink (see https://php.watch/versions/8.0/fatal-error-suppression)


improve unlinking files in pdf generation

6d937ef

dpfaffenbauer approved these changes

View reviewed changes

dpfaffenbauer added this to the 3.0.6 milestone

dpfaffenbauer self-assigned this

dpfaffenbauer added the bug label

dpfaffenbauer merged commit 3db6176 into coreshop:3.0

412 checks passed

Member

dpfaffenbauer commented May 26, 2023

thanks

solverat deleted the wk_file_fix branch

May 26, 2023 14:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment