Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed jmsSerializer type from ArrayTransformerInterface to Serializ… #2291

Conversation

BlackbitDevs
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Adjusted OrderController according to JsonHelperTrait Pimcore using SerializerInterface instead of ArrayTransformerInterface

https://github.com/pimcore/pimcore/blob/81be9535e5b461fe045c0cce6cf3d94be92901bf/bundles/AdminBundle/Controller/AdminController.php#L34:36
abstract class AdminController extends UserAwareController implements AdminControllerInterface
{
    use JsonHelperTrait;

@dpfaffenbauer
Copy link
Member

@BlackbitDevs that doesn't work, CoreShop is using JMS Serializer, where as Pimcore injects the Symfony Serializer. We already changed that in the Pimcore 10.6 compatibility PR: #2285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants