Adjusted locale switcher for internal shop pages without translations #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpfaffenbauer
requested changes
May 2, 2023
src/CoreShop/Bundle/FrontendBundle/Twig/LocaleSwitcherExtension.php
Outdated
Show resolved
Hide resolved
dpfaffenbauer
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing locale switcher doesn't change locale for static route pages such as /shop/login, /shop/cart, /shop/customer/profile etc. This happens because
$documentinCoreShop/src/CoreShop/Bundle/FrontendBundle/Twig/LocaleSwitcherExtension.php
Line 50 in 738d977
/shopas document but the remaining CoreShop pages are handled via static routes, even a request for/shop/loginwill have$document = /shop. Of course this document may have translations and so the wrong links get created.This PR checks if a static route has been used for current request. In this case links for this static route (but for other locale) will get created. This avoids having to add all internal shop pages as Pimcore Documents.