Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropzone): Изменен тип аргумента в onDrop на File[] #1194

Merged
merged 1 commit into from
May 28, 2024

Conversation

EGNKupava
Copy link
Contributor

@EGNKupava EGNKupava commented May 4, 2024

👋

BREAKING CHANGE: Изменен тип принимаемого аругумента в обработчике onDrop c FileList на File[]

Опишите проблему

Имеем такую конструкцию
image
Dropzone + Attach
Attach возвращает файлы типа File[], Dropzone -> FileList

Для консистентности перевел тип Dropzone в File[]
Наврядли кто-то использовал методы FileList-а item например, но все-же это мажорка

Изменен тип принимаемого аругумента в обработчике onDrop c FileList на File[]

BREAKING CHANGE: Изменен тип принимаемого аругумента в обработчике onDrop c FileList на File[]
Copy link

changeset-bot bot commented May 4, 2024

🦋 Changeset detected

Latest commit: e49e229

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-dropzone Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8950813321

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 84.385%

Totals Coverage Status
Change from base Build 8934908977: -0.006%
Covered Lines: 9519
Relevant Lines: 10418

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 merged commit fbaa7f2 into master May 28, 2024
7 checks passed
@Valeri8888 Valeri8888 deleted the feat/dropzone-ondrop branch May 28, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants