Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(product-cover): add new component #1103

Merged
merged 2 commits into from
May 24, 2024
Merged

feat(product-cover): add new component #1103

merged 2 commits into from
May 24, 2024

Conversation

Valeri8888
Copy link
Collaborator

@Valeri8888 Valeri8888 commented Feb 14, 2024 •
edited by SiebenSieben

SCR-20240427-kjhx

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2024 •
edited

🦋 Changeset detected

Latest commit: 0685b69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-product-cover Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Feb 14, 2024 •
edited

Bundle size report

Entry point Size (minified)
product-cover/index.js 39.6 (+39.60 KB🔺)

@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited

Pull Request Test Coverage Report for Build 8983383524

Details

  • 104 of 105 (99.05%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 84.426%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/product-cover/src/components/image-card/Component.tsx 20 21 95.24%
Totals Coverage Status
Change from base Build 8934908977: 0.04%
Covered Lines: 9623
Relevant Lines: 10523
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 4cc0e59 to 8fec28d Compare February 15, 2024 06:42
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from e9de8fc to 1cc2db1 Compare February 15, 2024 07:17
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 1cc2db1 to 1e7b818 Compare February 19, 2024 09:40
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 1e7b818 to 62219c7 Compare February 21, 2024 08:51
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben changed the title feat(bank-card-view): add new component [WIP] feat(bank-card-view): add new component Feb 28, 2024
@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 62219c7 to efe7768 Compare April 23, 2024 07:18
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben changed the title [WIP] feat(bank-card-view): add new component feat(bank-card-view): add new component Apr 24, 2024
@SiebenSieben SiebenSieben requested review from fulcanellee and Oladii and removed request for EGNKupava April 24, 2024 05:04
@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from efe7768 to 216dd35 Compare April 25, 2024 08:55
@Valeri8888 Valeri8888 removed the paused label Apr 25, 2024
@Valeri8888 Valeri8888 changed the title feat(bank-card-view): add new component feat(product-cover): add new component Apr 25, 2024
@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 8ea54b8 to 895fa18 Compare April 25, 2024 09:28
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 895fa18 to e28fb40 Compare April 26, 2024 13:28
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 81d5d03 to c170acb Compare May 2, 2024 14:50
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from c170acb to 30f5250 Compare May 6, 2024 11:57
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 30f5250 to fed30f3 Compare May 7, 2024 09:58
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from fed30f3 to 55db9fb Compare May 23, 2024 12:32
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 force-pushed the feat/new-component_bank-card-mini branch from 55db9fb to 0685b69 Compare May 23, 2024 13:15
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 merged commit b0699cc into master May 24, 2024
7 checks passed
@Valeri8888 Valeri8888 deleted the feat/new-component_bank-card-mini branch May 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@fulcanellee fulcanellee fulcanellee approved these changes

@Oladii Oladii Oladii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Valeri8888 @core-ds-bot @coveralls @SiebenSieben @reme3d2y @fulcanellee @Oladii