Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MongoJack and consolidate MongoDB utils #837

Open
wants to merge 44 commits into
base: dev
Choose a base branch
from
Open

Remove MongoJack and consolidate MongoDB utils #837

wants to merge 44 commits into from

Commits on Nov 8, 2022

  1. Remove MongoJack and consolidate utils 

    A process that started many years ago, this removes the MongoJack dependency and migrates the `Persistence` module and its collections to the `AnalysisDB` and `AnalysisCollection` types that were set to replace it.

In light of a possible database switch in the near future, it seemed more straightforward to continue to use `String` based IDs everywhere, instead of switching to a MongoDB specific `ObjectID` type.

Our average collection already uses `String` IDs, but this will require a migration for aggregation areas, data sources, and data groups.
    @trevorgerhardt
    trevorgerhardt committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    aa1b9cd View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Remove unnecessary toString()s

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    bd77ee5 View commit details
    Browse the repository at this point in the history

  2. Retrieve each modification type manually

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    a929020 View commit details
    Browse the repository at this point in the history

  3. Prefer Lists over arrays for MongoDB parsing

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    8f4a40c View commit details
    Browse the repository at this point in the history

  4. Refactor to handle new MongoDB changes 

    - Prefer `Set` vs `EnumSet` (BSON parser can handle `Set` by default)
- Prefer `List`s over arrays.
    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    efb4ec5 View commit details
    Browse the repository at this point in the history

  5. Update MongoDB driver

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    f5c632f View commit details
    Browse the repository at this point in the history

  6. Prefer var

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    de55f9f View commit details
    Browse the repository at this point in the history

  7. Compare to first grid's zoom

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    6b3fd5e View commit details
    Browse the repository at this point in the history

  8. Use native MongoDB Geometry type

    @trevorgerhardt
    trevorgerhardt committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    44e2d47 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. Simplify delete source set

    @trevorgerhardt
    trevorgerhardt committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    325eea9 View commit details
    Browse the repository at this point in the history

  2. Additional GridResultWriter clean up

    @trevorgerhardt
    trevorgerhardt committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    06e7cb4 View commit details
    Browse the repository at this point in the history

  3. Create a utility method to gzip a File

    @trevorgerhardt
    trevorgerhardt committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    ea12ed3 View commit details
    Browse the repository at this point in the history

  4. Add zero argument constructor back

    @trevorgerhardt
    trevorgerhardt committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    341f317 View commit details
    Browse the repository at this point in the history

  5. Clean up result writers

    @trevorgerhardt
    trevorgerhardt committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    b29a750 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Pass components directly to BundleController

    @trevorgerhardt
    trevorgerhardt committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    8d215b7 View commit details
    Browse the repository at this point in the history

  2. Use BsonDiscriminators for modifications

    @trevorgerhardt
    trevorgerhardt committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7546f20 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary Codecs

    @trevorgerhardt
    trevorgerhardt committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    71eedc0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Update src/main/java/com/conveyal/analysis/datasource/derivation/Aggr… 

    …egationAreaDerivation.java

Co-authored-by: Anson Stewart <[email protected]>
    @trevorgerhardt @ansoncfit
    trevorgerhardt and ansoncfit committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    c4b9ca9 View commit details
    Browse the repository at this point in the history

  2. Update src/main/java/com/conveyal/analysis/models/BaseModel.java 

    Co-authored-by: Anson Stewart <[email protected]>
    @trevorgerhardt @ansoncfit
    trevorgerhardt and ansoncfit committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    486abb7 View commit details
    Browse the repository at this point in the history

  3. Update src/main/java/com/conveyal/analysis/results/GridResultWriter.java 

    Co-authored-by: Anson Stewart <[email protected]>
    @trevorgerhardt @ansoncfit
    trevorgerhardt and ansoncfit committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d5c1620 View commit details
    Browse the repository at this point in the history

  4. Update src/main/java/com/conveyal/analysis/controllers/RegionalAnalys… 

    …isController.java

Co-authored-by: Anson Stewart <[email protected]>
    @trevorgerhardt @ansoncfit
    trevorgerhardt and ansoncfit committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    8e1a0d1 View commit details
    Browse the repository at this point in the history

  5. Update src/main/java/com/conveyal/analysis/controllers/RegionalAnalys… 

    …isController.java

Co-authored-by: Anson Stewart <[email protected]>
    @trevorgerhardt @ansoncfit
    trevorgerhardt and ansoncfit committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    7d9a45e View commit details
    Browse the repository at this point in the history

  6. Update src/main/java/com/conveyal/analysis/controllers/RegionalAnalys… 

    …isController.java

Co-authored-by: Anson Stewart <[email protected]>
    @trevorgerhardt @ansoncfit
    trevorgerhardt and ansoncfit committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d885ba6 View commit details
    Browse the repository at this point in the history

  7. Remove now unnecessary FIXME comment

    @trevorgerhardt
    trevorgerhardt committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    3f4bb12 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'remove-mongojack' of https://github.com/conveyal/r5 int… 

    …o remove-mongojack
    @trevorgerhardt
    trevorgerhardt committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5a3d49d View commit details
    Browse the repository at this point in the history

  9. Add accidentally removed @Override

    @trevorgerhardt
    trevorgerhardt committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    9ac1659 View commit details
    Browse the repository at this point in the history

  10. Use the actual return type, instead of the generic Object type

    @trevorgerhardt
    trevorgerhardt committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    1dfc172 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Add BsonDiscriminators to DecayFunctions 

    Simplify the creation of MongoDB codecs by using annotations instead.
    @trevorgerhardt
    trevorgerhardt committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    432d961 View commit details
    Browse the repository at this point in the history

  2. Add synchronized back to terminate method

    @trevorgerhardt
    trevorgerhardt committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b66a4be View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Revert comment auto-formatting

    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5187485 View commit details
    Browse the repository at this point in the history

  2. Revert comment auto-formatting

    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c2ae60b View commit details
    Browse the repository at this point in the history

  3. Revert comment auto-formatting

    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    423f05e View commit details
    Browse the repository at this point in the history

  4. Convert toStreetModeSet to take a single Set 

    Fixes an Intellij warning about unchecked generics.
    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    29ed72b View commit details
    Browse the repository at this point in the history

  5. Switch AnalysisRequest back to taking strings as modes

    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    de9ed5f View commit details
    Browse the repository at this point in the history

  6. Update getScenarioJsonUrl 

    Include the bundle ID and scenario ID so that the request object does not need to be fetched and deserialized.
    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    dd3e49a View commit details
    Browse the repository at this point in the history

  7. Clean up EnumSet changes

    @trevorgerhardt
    trevorgerhardt committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1c4e3a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. Remove gtfsCache component dependency 

    Make `GTFSCache.getFileKey` static to enable `BundleController` to operate without depending on the `GTFSCache` component.
    @trevorgerhardt
    trevorgerhardt committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    7a0b1bf View commit details
    Browse the repository at this point in the history

  2. Implement TODO added in last commit 

    Note: this endpoint is currently unused.
    @trevorgerhardt
    trevorgerhardt committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    7865c74 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Merge branch 'dev' into remove-mongojack

    @trevorgerhardt
    trevorgerhardt committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    99e848d View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2022

  1. Throw a "not found error" when grid does not exist

    @trevorgerhardt
    trevorgerhardt committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    552b3d7 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @trevorgerhardt
    trevorgerhardt committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    b7eedd9 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Merge branch 'dev' into remove-mongojack

    @trevorgerhardt
    trevorgerhardt committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    12d76ef View commit details
    Browse the repository at this point in the history

  2. Remove unused imports

    @trevorgerhardt
    trevorgerhardt committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    378e8a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Merge branch 'dev' into remove-mongojack

    @trevorgerhardt
    trevorgerhardt committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    02f9319 View commit details
    Browse the repository at this point in the history