Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX sorting with datetime from Nextras ORM #917

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FIX sorting with datetime from Nextras ORM #917

wants to merge 2 commits into from

Conversation

suchoproduction
Copy link 

Error
Cannot use object of type Nextras\Dbal\Result\Row as array

screencapture-mrhoreca-localhost-8828-locale-translator-my-category-type-2020-09-02-19_04_42

@suchoproduction
Update ArrayDataSource.php
ecec5c4 
```
Error
Cannot use object of type Nextras\Dbal\Result\Row as array
```
@suchoproduction
Update ArrayDataSource.php
8e80413 
Edit tabs
@f3l1x
Copy link
Member

f3l1x commented Nov 24, 2021

Can you please add some tests?

@radimvaculik
Copy link
Member

@suchoproduction Could you rebase the branch and add some tests, please? Thanks.

@radimvaculik
Copy link
Member

@hrach Could you take a look at it, please?

hrach
hrach approved these changes Aug 22, 2023
View reviewed changes
Copy link

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radimvaculik
Copy link
Member

@suchoproduction Please, rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrach hrach hrach approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suchoproduction @f3l1x @radimvaculik @hrach