Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Update podman network docs #22594

Merged

Conversation

radar07
Copy link
Contributor

@radar07 radar07 commented May 3, 2024

Update the podman network docs to specify that the default rootless networking tool has been swapped from slirp4netns to pasta.

Fixes: 22543

Does this PR introduce a user-facing change?

None

@radar07 radar07 force-pushed the default-rootless-network-docs branch from 9b98b6c to 3560075 Compare May 4, 2024 07:05
@radar07 radar07 requested a review from lahwaacz May 4, 2024 15:09
docs/source/markdown/podman-network.1.md Outdated Show resolved Hide resolved
@radar07 radar07 force-pushed the default-rootless-network-docs branch from 3560075 to cc9a51c Compare May 4, 2024 17:51
docs/source/markdown/options/network.md Outdated Show resolved Hide resolved
docs/source/markdown/podman-network.1.md Show resolved Hide resolved
docs/source/markdown/podman-network.1.md Outdated Show resolved Hide resolved
docs/source/markdown/podman-network.1.md Outdated Show resolved Hide resolved
@radar07 radar07 force-pushed the default-rootless-network-docs branch from cc9a51c to 8d1b7e1 Compare May 7, 2024 14:38
@radar07
Copy link
Contributor Author

radar07 commented May 7, 2024

@Luap99
Copy link
Member

Luap99 commented May 7, 2024

@radar07 radar07 force-pushed the default-rootless-network-docs branch from 8d1b7e1 to 86cb0c5 Compare May 8, 2024 15:52
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chnages LGTM, we can worry about the tutorials later, let's get the fix into the man pages for now

@radar07 Can you fix your commit message and remove the

fix

fix

fix

this should also make the DCO check pass

Update the podman network docs to specify that the default rootless
networking tool has been swapped from slirp4netns to pasta.

Signed-off-by: Pranav RK <[email protected]>
@radar07 radar07 force-pushed the default-rootless-network-docs branch from 86cb0c5 to 9a8c343 Compare May 17, 2024 13:35
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mheon PTAL

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lahwaacz, Luap99, radar07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@mheon
Copy link
Member

mheon commented May 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d0ed271 into containers:main May 21, 2024
39 of 41 checks passed
@Luap99
Copy link
Member

Luap99 commented May 21, 2024

/cherry-pick v5.1

@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: new pull request created: #22772

In response to this:

/cherry-pick v5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated documentation: slirp4netns vs pasta
5 participants