-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.4.1-crio] Bump c/common to v0.52.0 #22355
base: v4.4.1-crio
Are you sure you want to change the base?
[v4.4.1-crio] Bump c/common to v0.52.0 #22355
Conversation
As the title says, bumping the c/common package to v0.52.0 in the v4.4.1-crio branch via a request from the CRI-O team. Addresses: https://issues.redhat.com/browse/OCPBUGS-32144 [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
@kwilczynski PTAL This is dragging a ton of stuff in, I hope it's not too much. |
github.com/containers/conmon v2.0.20+incompatible | ||
github.com/containers/image/v5 v5.24.1 | ||
github.com/containers/image/v5 v5.25.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns with CRI-O release 1.25
. Newer releases are already on version 5.27.0
or newer.
github.com/containernetworking/cni v1.1.2 | ||
github.com/containernetworking/plugins v1.2.0 | ||
github.com/containers/buildah v1.29.3 | ||
github.com/containers/common v0.51.3 | ||
github.com/containers/common v0.52.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns with CRI-O release 1.25
. Newer releases are already on version 0.53.0
or newer.
@TomSweeneyRedHat, the two most important dependencies here for us are the We are good to go, I believe. |
/approve |
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@TomSweeneyRedHat, even though we look good from our key dependencies point of view, we have some anciliary dependency issues per: vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:122:12: undefined: system.LCOWSupported
vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:157:12: undefined: system.LCOWSupported Let me have a look as to how we resolved this in CRI-O. I believe a dependency update would fix this. |
This missing method issue has been fixed in the following release of the We should upgrade the dependency to version |
github.com/opencontainers/runc v1.1.12 | ||
github.com/opencontainers/runtime-spec v1.1.0-rc.1 | ||
github.com/opencontainers/runtime-tools v0.9.1-0.20221014010322-58c91d646d86 | ||
github.com/opencontainers/runtime-tools v0.9.1-0.20221107090550-2e043c6bd626 | ||
github.com/opencontainers/selinux v1.11.0 | ||
github.com/openshift/imagebuilder v1.2.4-0.20220711175835-4151e43600df |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomSweeneyRedHat, if possible, this needs a version bump to:
github.com/openshift/imagebuilder v1.2.4-0.20220711175835-4151e43600df | |
github.com/openshift/imagebuilder v1.2.4 |
This looks confusing; however, it's how this project tagged their release.
@TomSweeneyRedHat, do you think you could see about these comments:
To fix the build issue and potentially also move forward with this branch? I would be much obliged. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
As the title says, bumping the c/common package to v0.52.0
in the v4.4.1-crio branch via a request from the CRI-O team.
Addresses: https://issues.redhat.com/browse/OCPBUGS-32144
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?