chore: table column ellipsis #7196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
cdrage and
lstocchi
and removed request for
a team
lstocchi
approved these changes
May 14, 2024
There was a problem hiding this comment.
I wonder if we should show like a tooltip with full text in such cases so if i see a cut title/value, i just have to hover the cell. Atm there is no way to manually increase the size of a column so if i'm using a small screen and i cannot actually increase the full window i have no chance to read the cut value.
BTW the ellipsis works fine 👍
axel7083
approved these changes
May 14, 2024
Adds ellipsis to the standard table components when columns are too narrow: column headers, simple columns, and duration columns. For the header a div is added so that the sort indicators are always visible, and DurationColumn can simplify by just being a SimpleColumn. This does not cover any custom columns, of which there are many. Fixes containers#7195. Signed-off-by: Tim deBoer <[email protected]>
|
Rebased. @lstocchi good idea, but I will take it in follow-up PR b/c Tooltip is having issues with z-order when I tried it quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ellipsis to the standard table components when columns are too narrow: column headers, simple columns, and duration columns. For the header a div is added so that the sort indicators are always visible, and DurationColumn can simplify by just being a SimpleColumn.
This does not cover any custom columns, of which there are many to fix in future PRs.
Screenshot / video of UI
Before:
Used PR #7184 to make it easier to get this all in one image and screenshot is somewhat arbitrary, but note Environment header moving off to the left and Age header getting pushed to the right, months and MB cutoff.
After:
What issues does this PR fix or reference?
Fixes #7195.
How to test this PR?
Images view with #7184 used for image above, but there are SimpleColumns elsewhere. If you don't have any especially long content at the moment use ctrl-+ to make the font bigger.