-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables: use ellipsis for narrow columns #7195
Labels
Comments
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
May 13, 2024
Adds ellipsis to the standard table components when columns are too narrow: column headers, simple columns, and duration columns. For the header a div is added so that the sort indicators are always visible, and DurationColumn can simplify by just being a SimpleColumn. This does not cover any custom columns, of which there are many. Fixes containers#7195. Signed-off-by: Tim deBoer <[email protected]>
I think this can be delayed until the next sprint with the table component is in UI library. I'm moving the files as part of #6903 so it'll probably make conflicts that can be prevented delaying the work on this issue |
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
May 15, 2024
Adds ellipsis to the standard table components when columns are too narrow: column headers, simple columns, and duration columns. For the header a div is added so that the sort indicators are always visible, and DurationColumn can simplify by just being a SimpleColumn. This does not cover any custom columns, of which there are many. Fixes containers#7195. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
added a commit
that referenced
this issue
May 15, 2024
Adds ellipsis to the standard table components when columns are too narrow: column headers, simple columns, and duration columns. For the header a div is added so that the sort indicators are always visible, and DurationColumn can simplify by just being a SimpleColumn. This does not cover any custom columns, of which there are many. Fixes #7195. Signed-off-by: Tim deBoer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your enhancement related to a problem? Please describe
The core Table component does not do a good job when columns are too narrow: when column headers are too wide they drift into other headers, and cells get cutoff at the column boundary.
Describe the solution you'd like
Column headers, SimpleColumn, and DurationColumn should use ellipsis when they're too wide. When headers are too wide the column sorting should still be visible.
There are lots of custom column renderers that need to do the same, this should just cover the core/component level for now.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: