-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(containerd-shim-wasm): add OpenTelemetry tracing library and feature #582
Open
Mossaka
wants to merge
11
commits into
containerd:main
Choose a base branch
from
Mossaka:otel-wasmtime
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
force-pushed
the
otel-wasmtime
branch
2 times, most recently
from
May 6, 2024 05:03
8a3f861
to
a00f739
Compare
Mossaka
force-pushed
the
otel-wasmtime
branch
2 times, most recently
from
May 16, 2024 22:42
4d578ab
to
d9f1fe7
Compare
Mossaka
changed the title
[DO NOT MERGE] WIP: wasmtime shim OpenTelemetry tracing support
wasmtime shim OpenTelemetry tracing support
May 16, 2024
Mossaka
commented
May 18, 2024
Mossaka
changed the title
wasmtime shim OpenTelemetry tracing support
feat(containerd-shim-wasm): add OpenTelemetry tracing library and feature
May 18, 2024
Could you please take a look on this PR 🙏🏻 @devigned @jsturtevant @jprendes @cpuguy83 |
cpuguy83
requested changes
May 20, 2024
jsturtevant
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, awesome to see that this has already been used to solve our startup perf!
this commit adds otel collector APIs and a new opentelemetry feature to the wasm shim Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
…n shim_main Signed-off-by: jiaxiao zhou <[email protected]>
this commit adds a new env var OTEL_EXPORTER_OTLP_PROTOCOL to configure different types of OTLP protocols such as grpc and http/protobuf by default, it uses http/protobuf Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Did a rebase of the PR and resolved all the comments. Could you please take another look, @cpuguy83 , @jsturtevant 🙏? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces OpenTelemetry feature and new APIs on the core crate to add tracing capabilities to the shim.
OTEL_EXPORTER_OTLP_ENDPOINT
environment variable to determine if the shim should be started with OpenTelemetry tracing.It builds on top of #564