-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.7] Add API go module #10189
base: release/1.7
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
41cb738
to
7ee92ff
Compare
7ee92ff
to
ddc2a76
Compare
ddc2a76
to
943a70a
Compare
Let's get this one into the next 1.7 release |
943a70a
to
5be6019
Compare
Signed-off-by: Akhil Mohan <[email protected]> (cherry picked from commit b16e357) Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Allows the api version to be imported and upgraded separately from the main module. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit e69efd5) Signed-off-by: Derek McGowan <[email protected]>
5be6019
to
4a2ca38
Compare
Trying this PR in moby/moby (through a replace rule), but looks like it's not happy. Perhaps I need to force a version for the API module, or something else (or the API package must have aliases in it; or removed, not sure;
|
OH! Maybe it works; but it's just version resolution; I manually added the API module, and that ... seems to go better. Only now it enforces go1.22, because that's what the API module defines? Line 3 in 114ef75
|
@thaJeztah there is going to be no way to actually use this new API submodule until this PR gets merged. I could possibly push the dev branch into this repo so we can use the hash, however, it seems easier to just get this merged knowing there will be follows ups with an updated tag. For the 1.22, that is currently on the api 1.8 which we could update, but it is the version we are going to import in 1.7 right now. |
Signed-off-by: Derek McGowan <[email protected]>
Added one more commit to so 1.7 is compatible with the 1.7 and 1.8 api. This PR is testing with 1.7 and #10278 shows it working with the latest 1.8 rc. This should be ready to merge now. |
Add api go module to 1.7. The plan is we do not need to update 1.7 to the 1.8 api go module if we separate it into its like we have done with main. The changes needed are minimal.
This helps the upgrade path from 1.7 to 2.0. After updating to 1.7, it should be easier to update to 2.0 since the api module can be just be upgraded to 1.8 and the latest containerd 1.7 will use the api package from the module.
For those not upgrading to 2.0 right away, the change should be invisible beside an extra dependency showing up in go module. We shouldn't need to do this for 1.6 since this only effects importers who are upgrading. In cases where an import is trying to stay on 1.6 but a dependency uses the latest version of 1.7, go mod would already forces the upgrade anyway.