CT-42/CT-147 #50
Open
CT-42/CT-147 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RafaelRtx
commented
Jun 20, 2024
RafaelRtx
commented
- Adicionada a propriedade sort de ordenação à interface e DTO de paginação.
- Adicionado arquivo Typescript com mocks de conversas de usuários
- Implementada a rota /conversations que permite listar as conversas de usuários com a utilização de parâmetros de url de busca (search) e paginação (limit, offset, sort)
|
erickmarx
requested changes
Jun 20, 2024
| @@ -17,4 +17,7 @@ export class PaginationDTO implements IPagination { | |||
| @Min(0) | |||
| @IsNumber() | |||
| offset: number; | |||
|
|
|||
| @IsOptional() | |||
| sort: 'asc' | 'desc'; | |||
There was a problem hiding this comment.
Voce pode adicionar duas validações a mais aqui:
@IsString() para validar se é string
@isin() para validar se é 'asc' ou 'desc', o argumento é assim: ['asc','desc']
E não se preocupe caso não passe o parametro, por que a funcionalidade do IsOptional() anula os outros decorators caso não tenha valor.
|
|
||
| @Injectable() | ||
| export class ConversationService { | ||
| getConversations(filters: ISearchFilterWithPagination): IGetConversations[] { |
There was a problem hiding this comment.
Achei essa funcionalidade bastante complicada de ler, mas por ser uma implementação temporária está tudo bem
| @@ -1,4 +1,5 @@ | |||
| export interface IPagination { | |||
| limit: number; | |||
| offset: number; | |||
| sort: 'asc' | 'desc'; | |||
There was a problem hiding this comment.
Talvez criar uma interface para o sort chamada ISort seja uma boa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.