CT-32/CT-144 #48
Merged
CT-32/CT-144 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RafaelRtx
commented
May 29, 2024
RafaelRtx
commented
- Adicionado patch-profile DTO para validação
- Adicionada patch-profile interface para o método PATCH na rota profile/me
- Adicionada funcionalidade do usuário alterar os dados de perfil name, username, email ou birthDate usando o método http PATCH na rota profile/me
erickmarx
requested changes
May 31, 2024
There was a problem hiding this comment.
Na função patchMe na service, não é necessario fazer a desestruturação e reestruturação do objeto validado vindo da controller, da mesma forma que é redundante validar cada valor vindo do body, sendo possivel dar essa responsabilidade ao prisma/relacional.
Se houver duvidas sobre o que foi apontado aqui, pode me chamar no discord, vai ser um prazer te ajudar a melhorar.
… changes to profile repository
erickmarx
approved these changes
Jun 4, 2024
|
erickmarx
approved these changes
Jun 4, 2024
natanaelsc
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.