Add ArraySegment<byte> as native supported type #2219
+38
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aim is to be able to provide pooled buffers with an adjustable offset and count to the library. This changes very little of the actual logic and does not break existing API and works on all .NET versions
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to be able to provide pooled buffers with an adjustable offset and count to the library.
This changes very little of the existing logic and does not break existing API and works on all .NET versions.
The ArraySegment will now be natively supported (like string, long or byte[]) without needing a user provided serializer. It also allows the use of pooled buffers and will help get the maximum performance out of the library.
This is one of the least invasive ways to add support for this feature that I found. (Span<>, Memory<> need recent versions and require changing the buffer pinning code).