Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/keepLastN #136

Merged
merged 5 commits into from May 26, 2024
Merged

Conversation

sriharimalagi
Copy link
Contributor

@sriharimalagi sriharimalagi commented Apr 16, 2024

Pull Request type

  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

If keepLastN is passed as part of input parameters of a DO_WHILE task, then the old / stale iterations' output data shall be removed while executing the DO_WHILE task.

Describe the new behavior from this PR, and why it's needed
Issue # 134

Alternatives considered

Describe alternative implementation you have considered

@v1r3n v1r3n merged commit 3e85e96 into conductor-oss:main May 26, 2024
@v1r3n
Copy link
Collaborator

v1r3n commented May 26, 2024

Hi @sriharimalagi can you follow up with a PR to add unit test for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants