Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update.yml workflow (and initializing workflow init.yml) #937

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented May 10, 2024

Description

Introducing a replacement to the sync.yml workflow. Instead of pushing changes from a centralized location we empower individual repos to pull the files they wish to use (these can even be pulled from any repository, not just conda/infrastructure).

This workflow has been implemented and tested in the conda-sandbox:

Since the workflow is now a pull process instead of a push process we need to also offer a means of initializing a repository. This is done using the new manually triggered init.yml workflow and allows us to specify where to push the update.yml workflow. The init.yml workflow can also be used to "repair" the update.yml script if ever a broken instance is distributed.

Depends on conda/governance#146
Resolves #678
Resolves #699

@kenodegard kenodegard requested a review from a team as a code owner May 10, 2024 18:48
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 10, 2024
kenodegard added a commit to kenodegard/conda-sandbox-upstream that referenced this pull request May 13, 2024
jezdez
jezdez previously approved these changes May 14, 2024
Comment on lines 1 to 5
conda/infrastructure:
# [required] general files and workflows
- CODE_OF_CONDUCT.md
- .github/workflows/cla.yml
- .github/workflows/update.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jezdez a recent idea I had was to move the primary copy of the short version CODE_OF_CONDUCT.md to https://github.com/conda/governance:

Suggested change
conda/infrastructure:
# [required] general files and workflows
- CODE_OF_CONDUCT.md
- .github/workflows/cla.yml
- .github/workflows/update.yml
conda/governance:
# [required] community files
- src: CODE_OF_CONDUCT_SHORT.md
dst: CODE_OF_CONDUCT.md
conda/infrastructure:
# [required] general workflows
- .github/workflows/cla.yml
- .github/workflows/update.yml

thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we could also create a .github repo for the org and add some of this shared content there

ref: https://github.com/orgs/community/discussions/22144#discussioncomment-3235649

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have https://github.com/conda/.github for the org README.md.

I've been very hesitant to do more with that repo since only some select files are shared with the downstream projects and we sync more than just those files. In some cases we even sync different files to different projects (e.g. not all projects have the same issue templates).

My other concern was the git archives, AFAIK these wont include any of the special files defined in the .github repo so the archives would be an incomplete artifact.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jezdez a recent idea I had was to move the primary copy of the short version CODE_OF_CONDUCT.md to conda/governance:

Yeah, now that we have conda/governance, we should use it as the source of truth for governance docs like the CoC, it just didn't exist in the main org when we adopted the CoC.

I hear @jakirkham's point though about having a copy in .github though, it's not a loss to have a copy there as well, but for completeness’s sake, having a copy in every repo doesn't hurt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I misunderstood

we already sync files to https://github.com/conda/.github using the old sync workflow (see the workflow and the associated config)

all of the projects using the old sync workflow will be migrated to this new workflow soon

@kenodegard kenodegard changed the title Add update.yml workflow Add update.yml workflow (and initializing workflow init.yml) Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: Approved
4 participants