Allow over-writing existing targets #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the conda environment, the same file may be written to multiple times (eg. if a specific lib.so file exists, multiple conda packages may have it and at pack time conda-pack will pull from the cache'd original copy of the package and copy it in; when multiple packages have the same lib.so file they'll over-write each other). shutil.copy2 doesn't handle overwriting existing symlinks cleanly: it overwrites files silently but fails on creating a symlink (probably worth a separate PR to cpython later). Allow for this by explicitly deleting existing targets.
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @kunalb. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#946), and ping the bot to refresh the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depending on the conda environment, the same file may be written to multiple times (eg. if a specific lib.so file exists, multiple conda packages may have it and at pack time conda-pack will pull from the cache'd original copy of the package and copy it in; when multiple packages have the same lib.so file they'll over-write each other).
shutil.copy2 doesn't handle overwriting existing symlinks cleanly: it overwrites files silently but fails on creating a symlink (probably worth a separate PR to cpython later). Allow for this by explicitly deleting existing targets.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?