Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privatize internal conda-store API #820

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Privatize internal conda-store API #820

wants to merge 5 commits into from

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented May 6, 2024 •
edited

Closes #723.

Description

This PR privatizes most of conda-store and conda-store-server in preparation for implementing an upcoming backwards compatibility policy.

This pull request:

  • Moves everything into _internal subpackages, except for a select few outward-facing APIs.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

No special testing requirements because new behavior has not been introduced; standard CI tests are sufficient.

@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit bc03847
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6639b6582f482c00084eafe2

@peytondmurray peytondmurray added area: documentation 📖 Improvements or additions to documentation area: api status: in progress 🏗 needs: review 👀 impact: high 🟥 This issue affects most of the conda-store users or is a critical issue area: user experience 👩🏻‍💻 Items impacting the end-user experience type: maintenance 🛠 and removed area: documentation 📖 Improvements or additions to documentation area: user experience 👩🏻‍💻 Items impacting the end-user experience labels May 7, 2024
@peytondmurray peytondmurray marked this pull request as ready for review May 7, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithraes pavithraes Awaiting requested review from pavithraes

@dcmcand dcmcand Awaiting requested review from dcmcand

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: api area: user experience 👩🏻‍💻 Items impacting the end-user experience impact: high 🟥 This issue affects most of the conda-store users or is a critical issue needs: review 👀 status: in progress 🏗 type: maintenance 🛠
Projects
conda-store 🐍
Status: In review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Privatize conda-store and conda-store-server internals
1 participant
@peytondmurray