DEV - Update dev workflows and CI #801
Conversation
Remove duplicate environment files
trallard
added
area: documentation 📖
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trallard
changed the title
| name: conda-store-server-dev | ||
| channels: | ||
| - conda-forge | ||
| - microsoft | ||
| - nodefaults | ||
| dependencies: | ||
| - python ==3.10 | ||
| # conda builds | ||
| - conda ==23.5.2 |
There was a problem hiding this comment.
Seems this was introduced in #522 -> going through the commits this seems was temporary while mamba-org/mamba#2715
Will remove it and see how it goes
| @@ -68,21 +68,20 @@ Source = "https://github.com/conda-incubator/conda-store" | |||
| [tool.hatch.version] | |||
| path = "conda_store_server/__init__.py" | |||
|
|
|||
| # when adding dev dependencies (not required conda-store-server) add them to the environment-dev.yaml file too | |||
There was a problem hiding this comment.
I am afraid that without a CI step that checks for this cross-file consistency, things will go out of sync eventually.
There was a problem hiding this comment.
+1 - will have to add that in a separate PR (already have other CI changes that build on this PR to simplify stuff and add consistency checks)
| name: conda-store-server-dev | ||
| channels: | ||
| - conda-forge | ||
| - microsoft | ||
| - nodefaults | ||
| dependencies: | ||
| - python ==3.10 | ||
| # conda builds | ||
| - conda ==23.5.2 |
There was a problem hiding this comment.
Seems this was introduced in #522 -> going through the commits this seems was temporary while mamba-org/mamba#2715
Will remove it and see how it goes
| @@ -68,21 +68,20 @@ Source = "https://github.com/conda-incubator/conda-store" | |||
| [tool.hatch.version] | |||
| path = "conda_store_server/__init__.py" | |||
|
|
|||
| # when adding dev dependencies (not required conda-store-server) add them to the environment-dev.yaml file too | |||
There was a problem hiding this comment.
+1 - will have to add that in a separate PR (already have other CI changes that build on this PR to simplify stuff and add consistency checks)
Co-authored-by: jaimergp <[email protected]>
…ubator/conda-store into trallard/separate-deps
Co-authored-by: jaimergp <[email protected]>
Split from #792
Description
environment.yamlfiles as no longer neededyamlfilesPull request checklist
Additional information
With this PR, at most, contributors/maintainers will need to regenerate/update their local conda environment.
How to test
💻 Locally:
condadevelopment environment (should useconda-store-server/environment-dev.yamlTo test the changes to the test GH workflows, you can use https://github.com/nektos/act and run the workflow or job accordingly. For example, to only run the conda-store integration tests:
act -j "integration-test-conda-store-server"