Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecr-login version #347

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

bartlett-ops
Copy link
Contributor

@bartlett-ops bartlett-ops commented Aug 5, 2022

Ready for review. This PR updates the amazon-ecr-credentials-helper library to enable support for AWS GovCloud.

Solves issue #346

Tom Bartlett added 3 commits August 15, 2022 15:09
Signed-off-by: Tom Bartlett <[email protected]>
Signed-off-by: Tom Bartlett <[email protected]>
Signed-off-by: Tom Bartlett <[email protected]>
@bartlett-ops
Copy link
Contributor Author

@xtremerui this is ready for review

Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for the fix.

@xtremerui xtremerui merged commit d4f0397 into concourse:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants