Rebase master 7.11.1 #8895
Merged
Rebase master 7.11.1 #8895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Troshin <[email protected]>
add shared path to SSM parameters
Signed-off-by: Rui Yang <[email protected]>
use stable website for internet test in watsjs
Signed-off-by: Hongkuan Wang <[email protected]>
Fix incorrect log message
remove json comment field due to error on renovate `Invalid configuration option: packageRules[3]._context` Signed-off-by: Rui Yang <[email protected]>
Update renovate.json
…nerd/containerd-vulnerability fix(deps): update module github.com/containerd/containerd to v1.7.11 [security]
…to-vulnerability fix(deps): update module golang.org/x/crypto to v0.17.0 [security]
…e/go-jose/v3-vulnerability fix(deps): update module github.com/go-jose/go-jose/v3 to v3.0.1 [security]
Signed-off-by: Rui Yang <[email protected]>
Signed-off-by: Rui Yang <[email protected]>
fix(deps): update all dependencies
fix(deps): update all dependencies
Signed-off-by: Rui Yang <[email protected]>
chore(deps): update javasript
Signed-off-by: Rui Yang <[email protected]>
Pulling go version other than relying on runner image in CodeQL scan
chore(deps): update all dependencies
fix(deps): update all dependencies
fix(deps): update all dependencies
Signed-off-by: Rui Yang <[email protected]>
fix(deps): update all dependencies
Signed-off-by: Rui Yang <[email protected]>
fix(deps): update all dependencies
Fix compilation error in topgun/k8s test
fix(deps): update all dependencies
Spimtav
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Everything seemed straightforward to my naive, contextless eyes. Just a couple of small feature requests / replacements and package improvements, that i could see. i don't really have anything to add design or implementation wise.
The only thing i'm curious about is if it's worth testing the SharedPath feature a bit more rigorously. For example, one test for the negative case (ie: SharedPath is empty), and maybe some corner cases too just in case (ie: the SharedPath exists but can't be found when looked up, the SharedPath exists but there's a network/read/whatever error on lookup, etc.).
Just an idea though, curious if you feel it would be necessary.
Spimtav
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebasing master for releasing v7.11.1